Open
Conversation
BestPricklyCactus
commented
Sep 22, 2025
BestPricklyCactus
commented
- Переод с коллбеков на саспенд функции и корутины
- Добавлено к запросу фактов запрос рандомных картинок
- Реализация решения ViewModel
| lateinit var catsPresenter: CatsPresenter | ||
|
|
||
| private val diContainer = DiContainer() | ||
| private var isPresenretMode = true |
There was a problem hiding this comment.
nit: опечатка isPresenterMode
| override fun onStop() { | ||
| if (isFinishing) { | ||
| catsPresenter.detachView() | ||
| catsPresenter.onStop() |
There was a problem hiding this comment.
нет проверки на инициализацию catsPresenter, в режиме isPresenterMode == false будет краш
| when (state) { | ||
| is Result.Success<*> -> { | ||
| if (state.data is Model) { | ||
| view.populate(Model(state.data.fact, state.data.imageUrl)) |
There was a problem hiding this comment.
лишнее пересоздание модели, можно скастить к Model
| private val _state = MutableStateFlow<Result>(Result.Error("Не получилось получить факт")) | ||
| val state: StateFlow<Result> = _state.asStateFlow() | ||
|
|
||
| val handler = CoroutineExceptionHandler { _, exception -> |
There was a problem hiding this comment.
можно сделать приватным, снаружи не нужен
| ::onShowToast | ||
| ) | ||
| viewModel.onInitComplete() | ||
| view.viewModel = viewModel |
There was a problem hiding this comment.
не стоит во вью подкладывать ссылку на вьюмодель, она там вообще не нужна
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.